Lunderberg commented on code in PR #13130:
URL: https://github.com/apache/tvm/pull/13130#discussion_r1019657256
##########
src/arith/rewrite_simplify.cc:
##########
@@ -1761,6 +1761,37 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const
AndNode* op) {
TVM_TRY_REWRITE(x == c1 && x != c2, x == c1 && c1 != c2);
TVM_TRY_REWRITE(x != c2 && x == c1, x == c1 && c1 != c2);
+
Review Comment:
Good call, and updated. There were a couple of the rewrite rules that had
incorrect behavior for negative numerators, so those are now fixed.
##########
src/arith/rewrite_simplify.cc:
##########
@@ -1761,6 +1761,37 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const
AndNode* op) {
TVM_TRY_REWRITE(x == c1 && x != c2, x == c1 && c1 != c2);
TVM_TRY_REWRITE(x != c2 && x == c1, x == c1 && c1 != c2);
+
Review Comment:
Good call, and updated. There were a couple of the rewrite rules that had
incorrect behavior for negative numerators, so those are now fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
