elvin-n commented on code in PR #13362:
URL: https://github.com/apache/tvm/pull/13362#discussion_r1022710053
##########
cmake/modules/OpenCL.cmake:
##########
@@ -49,12 +49,17 @@ else()
endif(USE_AOCL)
if(USE_OPENCL)
- if (NOT OpenCL_FOUND)
- find_package(OpenCL REQUIRED)
- endif()
- message(STATUS "Build with OpenCL support")
tvm_file_glob(GLOB RUNTIME_OPENCL_SRCS src/runtime/opencl/*.cc)
- list(APPEND TVM_RUNTIME_LINKER_LIBS ${OpenCL_LIBRARIES})
+ if (OpenCL_FOUND)
+ message(STATUS "Build with OpenCL support")
Review Comment:
This can happen only if this specific version of OpenCL has functions which
are not in the OpenCL standard. I hardly can imagine that tvm OpenCL runtime
can depend on such functions. All specific can be in OpenCL extensions which
can be a part of kernels, but not host API. Let's completely remove flow with
static linking and depending on OpenCL SDK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
