echuraev commented on code in PR #13349:
URL: https://github.com/apache/tvm/pull/13349#discussion_r1023577713
##########
python/tvm/rpc/tracker.py:
##########
@@ -348,7 +348,7 @@ def close(self, conn):
if "key" in conn._info:
for value in conn.put_values:
_, _, _, key = value
- rpc_key = key.split(":")[0]
+ rpc_key = key.rsplit(":", 1)[0]
Review Comment:
Could you please add a test on this change to highlight what is the fix
here? Probably `tests/python/unittest/test_runtime_rpc.py` is the right place
for such test. Also, maybe it is better to create a separate PR with this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
