guberti commented on PR #13242: URL: https://github.com/apache/tvm/pull/13242#issuecomment-1319204226
This pull request is ready for review! Would love reviews from @mkatanbaf (who's doing some microTVM + MetaSchedule work), @areusch, and @ekalda. Would also love a look from someone who's more familiar with TVMScript, and can critique my use of it :). That said, there are a few known issues in this PR I still need to fix: - There is a hack where I read dummy data from a TVMScript buffer to prevent TVM from seeing the buffers as "unused". I think I'm supposed to use T.reads/T.writes in this situation, but I could not make those functions work. - It's kinda gross for me to use `alter_op` to change the `requantize` ops to be integers. It would be much better if I could do this in the TIR schedules, but this does not work as I cannot alter the requantize constants. I had to disable a type check to make this hack work, so I would like to find a different solution before merging. - The output zero point for requantization in `tensordot.py` is a fixed value of `-128`. I need to fix this to be dynamic. In a following PR, I'll also address: - The `out_layout` attribute is not supported for my `conv2d` or `depthwise_conv2d` schedules. Adding this will let me get some timing results! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
