echuraev commented on code in PR #13420: URL: https://github.com/apache/tvm/pull/13420#discussion_r1026456535
########## tests/python/unittest/test_runtime_rpc.py: ########## @@ -448,10 +448,10 @@ def check_remote(): @tvm.testing.requires_rpc -def test_rpc_tracker_register(): [email protected]("device_key", ["test_device", "127.0.0.1:5555"]) Review Comment: Thank you for clarification! In verbal discussion, decided to fix all usage of key split in TVM code, create a function which have to do this split and write simple unit tests on it. To show that the key might has three parts separated by `:`: `host:port:unique_random_key`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
