ibsidorenko commented on code in PR #13242:
URL: https://github.com/apache/tvm/pull/13242#discussion_r1028959252
##########
src/relay/qnn/op/convolution.cc:
##########
@@ -53,7 +53,8 @@ bool QnnConv2DRel(const Array<Type>& types, int num_inputs,
const Attrs& attrs,
ICHECK(data->dtype == DataType::Int(8) || data->dtype == DataType::UInt(8) ||
data->dtype == DataType::Int(16))
<< "Expected qnn conv2d type(int8, uint8, int16) for input but was " <<
data->dtype;
- ICHECK(weight->dtype == DataType::Int(8) || weight->dtype ==
DataType::UInt(8))
+ ICHECK(weight->dtype == DataType::Int(8) || weight->dtype ==
DataType::UInt(8) ||
+ weight->dtype == DataType::Int(16))
<< "Expected qnn conv2d type(int8, uint8) for weight but was " <<
weight->dtype;
Review Comment:
```suggestion
<< "Expected qnn conv2d type(int8, uint8, int16) for weight but was "
<< weight->dtype;
```
added int16 in error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
