tqchen commented on code in PR #13489:
URL: https://github.com/apache/tvm/pull/13489#discussion_r1032846388
##########
tests/python/unittest/test_runtime_module_export.py:
##########
@@ -203,7 +204,10 @@ def verify_multi_c_mod_export():
synthetic_cpu_lib.import_module(f)
synthetic_cpu_lib.import_module(engine_module)
kwargs = {"options": ["-O2", "-std=c++17", "-I" +
header_file_dir_path.relpath("")]}
- synthetic_cpu_lib.export_library(path_lib, fcompile=False, **kwargs)
+ work_dir = temp.relpath("work_dir")
+ os.mkdir(work_dir)
+ synthetic_cpu_lib.export_library(path_lib, fcompile=False,
workspace_dir=work_dir, **kwargs)
+ assert os.path.exists(work_dir + "/devc.o")
Review Comment:
use
`os.path.join(work_dir, "devc.o")` so it can be portable across OS with
different separators
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
