quic-sanirudh commented on code in PR #13256:
URL: https://github.com/apache/tvm/pull/13256#discussion_r1034826123
##########
cmake/modules/Hexagon.cmake:
##########
@@ -178,6 +178,15 @@ if(BUILD_FOR_HEXAGON)
"${TVMRT_SOURCE_DIR}/hexagon/ops/*.cc"
)
+ include_directories(
+ "${TVMRT_SOURCE_DIR}/hexagon/ops"
+ )
+
+ set_source_files_properties(
+ "${TVMRT_SOURCE_DIR}/hexagon/ops/conv2d_quant_hvx.cc"
+ PROPERTIES COMPILE_FLAGS "-mhvx"
Review Comment:
Thanks for the review @cconvey.
I can add the details in the README or add a CMake check, but the `-mhvx`
flag was added to clang all the way back in 2017 in [LLVM 6.0
release](https://releases.llvm.org/6.0.0/docs/ReleaseNotes.html#changes-to-the-hexagon-target)
if not earlier, which predates the entire TVM project, so we can also probably
assume safely that the `-mhvx` flag will be available for practically anyone
building the TVM project now.
If you think it might still be better to add the check or the README change,
please let me know which one you think makes more sense and I can make that
change. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
