Lunderberg commented on PR #13530: URL: https://github.com/apache/tvm/pull/13530#issuecomment-1335850808
@wrongtest-intellif Thank you, and that makes sense! I wanted to make sure that I was extending, and not removing, existing functionality. Good point on the fraction representation. I was originally uncertain whether it would be overengineering, as compared to writing out the explicit integer formulas. The fun surprise for me was realizing that this approach would automatically handle cases where a user-provided parameter could be inferred to be a fraction (e.g. resizing with a cubic spline based on user-provided spline stiffness `alpha`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
