areusch commented on code in PR #13300:
URL: https://github.com/apache/tvm/pull/13300#discussion_r1038551741
##########
ci/jenkins/templates/arm_jenkinsfile.groovy.j2:
##########
@@ -0,0 +1,83 @@
+{% include "utils/base.groovy.j2" with context %}
Review Comment:
can we still put the ASF header in this file?
##########
docker/dev_common.sh:
##########
@@ -28,24 +28,10 @@ INVOCATION_PWD="$(pwd)"
GIT_TOPLEVEL=$(cd $(dirname ${BASH_SOURCE[0]}) && git rev-parse
--show-toplevel)
-function filter_jenkinsfile() {
- local echo_on=0;
- while read line; do
- if [ "${line}" == "// NOTE: these lines are scanned by
docker/dev_common.sh. Please update the regex as needed. -->" ]; then
- echo_on=1
- elif [ "${line}" == "// <--- End of regex-scanned config." ]; then
- break
- elif [ ${echo_on} -eq 1 ]; then
- echo "$line"
- fi
- done
-}
-
-
function lookup_image_spec() {
- img_line=$(cat "${GIT_TOPLEVEL}/Jenkinsfile" | filter_jenkinsfile | grep
-E "^${1} = ")
+ img_line=$(python3 "${GIT_TOPLEVEL}/ci/jenkins/data.py" "$1")
if [ -n "${img_line}" ]; then
- img_spec=$(echo "${img_line}" | sed -E "s/${1} = '([^\"]*)'/\1/")
+ img_spec=$(echo "${img_line}" | sed -E "s/${1} = \"([^\"]*)\"/\1/")
Review Comment:
i think this is unnecessary now right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
