csullivan commented on code in PR #13606: URL: https://github.com/apache/tvm/pull/13606#discussion_r1048001996
########## src/relay/backend/te_compiler_cache.cc: ########## @@ -1088,6 +1088,30 @@ std::tuple<Array<te::Tensor>, Array<runtime::NDArray>, std::string> LowerTECompu return std::make_tuple(tensor_outs, constants, lower_te_compute.candidate_name_); } +std::pair<Optional<tir::PrimFunc>, std::string> LowerToPrimFunc(const Function& relay_func, Review Comment: Should we add a check in here that relay_func has attr::kPrimitive to alert the user early if they are trying to lower a non-primitive function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
