Icemist commented on code in PR #13726:
URL: https://github.com/apache/tvm/pull/13726#discussion_r1064162325
##########
src/runtime/profiling.cc:
##########
@@ -894,15 +891,21 @@ PackedFunc WrapTimeEvaluator(PackedFunc pf, Device dev,
int number, int repeat,
std::max((min_repeat_ms / (duration_ms / number) + 1), number *
golden_ratio));
}
+ int64_t accum_t_nanos = 0;
// start timing
- Timer t = Timer::Start(dev);
for (int j = 0; j < number; ++j) {
+ // call preprocessing function
+ if (f_preproc != nullptr) {
+ f_preproc.CallPacked(args, &temp);
Review Comment:
> Another concern is whether we should have a `warmup` argument for
`time_evaluator` function, I think it's common in all frameworks' profiling
tools.
There is a pre-start call of the function, before starting the logic of
measurements. Do you think that one is not enough? Or warm it up with
something else?
```
// skip first time call, to activate lazy compilation components.
pf.CallPacked(args, &temp);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
