tkonolige commented on code in PR #13726: URL: https://github.com/apache/tvm/pull/13726#discussion_r1064968656
########## src/runtime/cuda/l2_cache_flush.cc: ########## @@ -0,0 +1,79 @@ +/* Review Comment: We don't like to include code from other projects in TVM unless it lives in the `3rdparty` directory. As this code is basically the same as https://github.com/NVIDIA/nvbench/blob/1a13a2e724b8aa8aee27649ac6878babb63862a6/nvbench/detail/l2flush.cuh, it should be moved into `3rdparty/nvbench` and the license header at the top should be changed to the one in the nvbench repository. @areusch is this acceptable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
