junrushao commented on code in PR #13791:
URL: https://github.com/apache/tvm/pull/13791#discussion_r1071518805
##########
.gitmodules:
##########
@@ -19,3 +19,6 @@
[submodule "3rdparty/OpenCL-Headers"]
path = 3rdparty/OpenCL-Headers
url = https://github.com/KhronosGroup/OpenCL-Headers.git
+[submodule "3rdparty/cnpy"]
+ path = 3rdparty/cnpy
+ url = https://github.com/rogersce/cnpy.git
Review Comment:
I was generally less aggressive when introducing new dependency. It doesn't
mean I don't like it in this case, but do you think we could use TVM's native
NDArray saving methods instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
