NicolaLancellotti commented on code in PR #13643:
URL: https://github.com/apache/tvm/pull/13643#discussion_r1072048375
##########
apps/microtvm/cmsisnn/Makefile:
##########
@@ -69,6 +69,18 @@ $(BUILD_DIR)/crt_backend_api.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/cr
$(QUIET)mkdir -p $(@D)
$(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+$(BUILD_DIR)/crt_runtime_api.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/crt_runtime_api.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
+$(BUILD_DIR)/func_registry.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/func_registry.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
+$(BUILD_DIR)/ndarray.o: $(STANDALONE_CRT_PATH)/src/runtime/crt/common/ndarray.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
Review Comment:
I've added an option `debug_last_error` to `CMSISNNCompilerConfigNode`.
The calls to `TVMAPISetLastError` and `TVMAPIGetLastError` are generated
only if this option is true.
When the option is false we no longer need the dependencies:
`crt_runtime_api.c`, `func_registry.c` and `ndarray.c`. We need them only when
the option is true.
I've also added a test, that checks if a model compiles with both values of
this option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
