ashutosh-arm commented on code in PR #13807:
URL: https://github.com/apache/tvm/pull/13807#discussion_r1082873726
##########
src/runtime/crt/aot_executor/aot_executor.c:
##########
@@ -203,17 +203,6 @@ int TVMAotExecutor_Init(TVMAotExecutor* executor,
TVMModuleHandle module_handle,
TVMNDArray_IncrementReference(array);
}
- for (i = 0; i < md->num_workspace_pools; ++i) {
- LOG_DEBUG("pools allocate[%d]: %s\n", i, md->workspace_pools[i].name);
-
- status = TVMNDArray_Empty(md->workspace_pools[i].num_shape,
md->workspace_pools[i].shape,
- md->workspace_pools[i].dtype, executor->device,
- &executor->args[arg_idx++]);
- if (status != 0) {
- return status;
- }
- }
- CHECK_EQ(0, md->num_constant_pools, "Constant pools not supported");
Review Comment:
Hi @alanmacd, LGTM overall. I am not sure about whether this check can be
removed. @d-smirnov knows more about it, so I will leave it to him.
##########
src/runtime/crt/aot_executor/aot_executor.c:
##########
@@ -203,17 +203,6 @@ int TVMAotExecutor_Init(TVMAotExecutor* executor,
TVMModuleHandle module_handle,
TVMNDArray_IncrementReference(array);
}
- for (i = 0; i < md->num_workspace_pools; ++i) {
- LOG_DEBUG("pools allocate[%d]: %s\n", i, md->workspace_pools[i].name);
-
- status = TVMNDArray_Empty(md->workspace_pools[i].num_shape,
md->workspace_pools[i].shape,
- md->workspace_pools[i].dtype, executor->device,
- &executor->args[arg_idx++]);
- if (status != 0) {
- return status;
- }
- }
- CHECK_EQ(0, md->num_constant_pools, "Constant pools not supported");
Review Comment:
Hi @alanmacd, LGTM overall! I am not sure about whether this check can be
removed. @d-smirnov knows more about it, so I will leave it to him.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
