driazati commented on code in PR #13829:
URL: https://github.com/apache/tvm/pull/13829#discussion_r1085959980
##########
docker/Dockerfile.ci_cortexm:
##########
@@ -76,12 +76,15 @@ COPY install/ubuntu_install_sccache.sh
/install/ubuntu_install_sccache.sh
RUN bash /install/ubuntu_install_sccache.sh
ENV PATH /opt/sccache:$PATH
-# Zephyr SDK deps
+# Zephyr Project
COPY install/ubuntu_install_zephyr.sh /install/ubuntu_install_zephyr.sh
COPY install/ubuntu_init_zephyr_project.sh
/install/ubuntu_init_zephyr_project.sh
-COPY install/ubuntu_install_zephyr_sdk.sh /install/ubuntu_install_zephyr_sdk.sh
RUN bash /install/ubuntu_install_zephyr.sh
ENV ZEPHYR_BASE=/opt/zephyrproject/zephyr
+
+#Zephyr SDK
Review Comment:
```suggestion
# Zephyr SDK
```
##########
docker/install/ubuntu_install_zephyr.sh:
##########
@@ -58,10 +78,4 @@ chmod -R o+w ${ZEPHYR_PROJECT_PATH}
mkdir zephyr/.cache
chmod o+rwx zephyr/.cache
-pip3 install -r /opt/zephyrproject/zephyr/scripts/requirements.txt
-
-# the requirements above overwrite junintparser with an older version, but it
is not
-# used so overwrite it again with the correct version
-pip3 install junitparser==2.4.2
Review Comment:
Isn't this just using the system Python with `python_cmd` here? This should
still re-install junitparser since that was a hack to get a specific version
working in CI which didn't agree with zephyr's requirements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
