krishnaraj36 commented on code in PR #13834:
URL: https://github.com/apache/tvm/pull/13834#discussion_r1086836460
##########
src/runtime/contrib/clml/clml_runtime.cc:
##########
@@ -1151,13 +1159,14 @@ class CLMLRuntime : public JSONRuntimeBase {
cl_arithmetic_mode_qcom cl_arithmetic_mode = MakeCLArithMode(cl_dtype);
int inputSize = input_.size();
auto output = MakeCLMLTensorFromJSONNode(node,
CL_TENSOR_LAYOUT_OPTIMAL_QCOM, cl_dtype);
+ cl_uint axis =
std::stoi(node.GetAttr<std::vector<std::string>>("axis")[0]);
cl_ml_tensor_qcom* concatInputs = new cl_ml_tensor_qcom[inputSize];
for (int i = 0; i < inputSize; i++) {
auto input = MakeCLMLTensorFromJSONEntry(node.GetInputs()[i], {},
CL_TENSOR_LAYOUT_OPTIMAL_QCOM,
cl_dtype);
concatInputs[i] = input->tensor;
}
- cl_ml_op_concat_desc_qcom concatDesc = {1, (cl_uint)inputSize,
cl_arithmetic_mode};
+ cl_ml_op_concat_desc_qcom concatDesc = {axis, (cl_uint)inputSize,
cl_arithmetic_mode};
Review Comment:
We have known issue for Concat layer in CLML pipeline when axis != 1, for
which team is working on. Once it is resolved we will add more test cases on
axis attributes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
