alanmacd commented on code in PR #13752:
URL: https://github.com/apache/tvm/pull/13752#discussion_r1087319226
##########
tests/python/relay/strategy/arm_cpu/test_quantized_convolution.py:
##########
@@ -95,6 +95,56 @@ def _get_mobilenet_v1_layer_attributes(layer_num):
return ((1, 1, 1, 1), (1, 1), True)
[email protected]("layer", range(2, 27, 2))
+def test_infinite_bias_detection(interpreter, layer):
+ """Some models (mainly MobileNetV1) have kernels with many output channels
full entirely of
+ zeroes. The VWW mdoel is one of these. This test confirms that the outputs
of these channels,
+ as computed by TensorFlow, are indeed not dependent upon the input values.
+ """
+
+ _, kernel, bias, output = _load_tflite_layer(interpreter, layer)
+ kernel_data, kernel_quant = kernel
+ bias_data, bias_quant = bias
+ output_data, output_quant = output
+ is_depthwise = _get_mobilenet_v1_layer_attributes(layer)[2]
+ assert not is_depthwise
+ assert kernel_data.shape[1] == kernel_data.shape[2] == 1
+
+ out_channels = kernel_data.shape[3]
+ fixed_channels = {}
+
+ out_zero_point = output_quant["zero_points"][0]
+ assert out_zero_point == -128
+
+ for i in range(out_channels):
+ # Skip over output channels with data
+ if np.any(kernel_data[i, 0, 0, :]):
+ continue
+
+ scale = bias_quant["scales"][i] / output_quant["scales"][0]
+ channel_constant = round(bias_data[i] * scale + out_zero_point)
+ clipped = min(127, max(-128, channel_constant))
+
+ out_channel_values = output_data[0, :, :, i].flatten()
+ assert all(x == clipped for x in out_channel_values)
+ fixed_channels[i] = clipped
+ print(f"Layer {layer} had {len(fixed_channels)}/{out_channels} empty!")
+
+ # We now need to compute values for the following depthwise layer
+ if layer == 26:
+ return
+
+ _, kernel, bias, output = _load_tflite_layer(interpreter, layer + 1)
+ kernel_data, kernel_quant = kernel
+ bias_data, bias_quant = bias
+ output_data, output_quant = output
+ is_depthwise = _get_mobilenet_v1_layer_attributes(layer + 1)[2]
Review Comment:
are some of these variable assignments unused in this block?
```suggestion
_, _, _, output = _load_tflite_layer(interpreter, layer + 1)
output_data, output_quant = output
is_depthwise = _get_mobilenet_v1_layer_attributes(layer + 1)[2]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
