quic-sanirudh commented on PR #13827:
URL: https://github.com/apache/tvm/pull/13827#issuecomment-1404974807
@zxybazh Thanks for the explanation. I understand that this change breaks
the assumption of `schedule_rule` and so it makes sense to close this PR
without merging. I would like to ask a couple of last questions if that's okay?
1. Is there a way to modify the attributes returned by the generic topi
compute?
- I'm asking this because the compute is in general the same for most
(if not all) targets. I couldn't find a way to just modify the attributes to
remove `schedule_rule` attribute from the `ComputeOp`, which would force these
targets to write the full compute function(or copy them from the generic
implementation), just to remove the attribute.
2. Second question is related to adding these attributes to specific
targets. If those custom schedule rules are beneficial for specific targets
like x86 or cuda, wouldn't it be better if the attribute is added for those
targets and keep the generic topi computes without any attributes.
- To me, somehow it feels wrong to add attributes that benefit specific
targets to the generic computes. Pleaser let me know your views on this.
Thanks again for the discussion, and I'll close this PR for now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
