ekalda commented on code in PR #13874:
URL: https://github.com/apache/tvm/pull/13874#discussion_r1093402135
##########
python/tvm/autotvm/tophub.py:
##########
@@ -110,6 +110,10 @@ def context(target, extra_files=None):
device = tgt.attrs.get("device", "")
if device != "":
possible_names.append(_alias(device))
+ # for cases when we do have explicitly defined -device in the target,
+ # we still might have information about it stored in keys container
+ # in other case we will load statistics for definitely irrelative stat
Review Comment:
Yeah I agree that applying same tuning statistics across different
implementations of the same architecture is quite sketchy, especially if it
happens in this non-transparent way it currently does. I'm also not sure how
often the database gets updated with new stats. I haven't seen compilation
crashing because of unsuitable tuning records from tophub myself, but if it
happens, that's really bad, since it makes tuning compulsory for being able to
compile a network with TVM. Also, sounds like a really difficult thing to
debug. But I suppose as long as AutoTVM is the default tuner (as it is for
tvmc) and therefore the one new potential users will use to evaluate TVM, it
should be kept in a state where its behaviour is representative of TVM's
capabilities. In my opinion it would be good if we didn't have 3 tuners to
maintain in parallel, but I suppose that's where the community is at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
