echuraev commented on code in PR #13867:
URL: https://github.com/apache/tvm/pull/13867#discussion_r1095428805
##########
docs/how_to/deploy/adreno.rst:
##########
@@ -15,41 +15,60 @@
specific language governing permissions and limitations
under the License.
-Deploy to Adreno GPU
-=======================================
+Deploy to Adreno™ GPU
+====================
-**Authors**: Daniil Barinov, Egor Churaev, Andrey Malyshev
+**Authors**: Daniil Barinov, Egor Churaev, Andrey Malyshev, Siva Rama Krishna
Introduction
------------
-Adreno is a series of graphics processing unit (GPU) semiconductor
+Adreno™ is a series of graphics processing unit (GPU) semiconductor
intellectual property cores developed by Qualcomm and used in many of
their SoCs.
-The Adreno GPU accelerates the rendering of complex geometries to
+The Adreno™ GPU accelerates the rendering of complex geometries to
deliver high-performance graphics and a rich user experience with low
power consumption.
-This guide will demonstrate :ref:`the benefits of using textures with
Adreno<advantages_of_the_textures>`,
-how to :ref:`build TVM with OpenCL<building_tvm_for_adreno>` (needed by Adreno
devices) and TVM RPC
-enabled. It will also provide :ref:`example
code<build_and_deploy_model_for_adreno>` to better understand the differences
in compiling and deploying models
-for Adreno devices.
+TVM supports deep learning acceleration on Adreno™ GPU by native OpenCL
backend of TVM and
+also through OpenCLML backend. Native OpenCL backend of TVM is enhanced to
make it
+Adreno™ friendly by incorporating texture memory usage and Adreno™ friendly
layouts.
+OpenCLML is an SDK release by Qualcomm that provides kernel acceleration
library
+for most of the deep learning operators.
-.. _advantages_of_the_textures:
+This guide is organized to demonstrate various design aspects of
-Advantages of the Textures
---------------------------
+- :ref:`OpenCL Backend Ehnahcements<opencl_enhancements>`
+- :ref:`About OpenCLML<about_openclml>`
+- :ref:`Build and Deploy<build_deploy>`
-One of the Adreno's advantages is the clever handling of textures. At
+
+
+.. how to :ref:`build TVM with OpenCL<building_tvm_for_adreno>` (needed by
Adreno™ devices) and TVM RPC
+.. enabled. It will also provide :ref:`example
code<build_and_deploy_model_for_adreno>` to better understand the differences
in compiling and deploying models
+.. for Adreno™ devices.
Review Comment:
If you speak about how the references looks like, then yes. But as far as I
understand, it is just the problems of the github representation. I took a look
into other rst doc files and all references looks there in the same way.
Originally, my comment was about the text:
```
.. how to :ref:`build TVM with OpenCL<building_tvm_for_adreno>` (needed by
Adreno™ devices) and TVM RPC
.. enabled. It will also provide :ref:`example
code<build_and_deploy_model_for_adreno>` to better understand the differences
in compiling and deploying models
.. for Adreno™ devices.
```
But for now the document was significantly reworked and this comment is not
relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
