Mousius commented on PR #13916: URL: https://github.com/apache/tvm/pull/13916#issuecomment-1418833607
Thanks for your reply @junrushao, > The flexibility of branch development offers opportunities for us to experiment with possible modes of agile development with quality. Agility in the scaffolding phase would help us to migrate development sooner to empower the community members who would like to have agile development and enable quicker migration as in [branch establishment guideline](https://github.com/apache/tvm/issues/13876). So I merged the code after I read through the current review state and ensured existing review requests on test cases are addressed adequately. Agile development is not justification to circumvent the review process established within TVM if the aim is to eventually merge `unity` into `main`; if this is the case, `unity` should be held to the same review guidelines as well as respecting the existing committers in the community. Agile development also prioritises working software, which benefits from high quality code reviews - given that both yourself and @tqchen are listed as co-authors but test coverage was missing in this PR, it would be good to get more eyes on the patches before we create a foundation of technical debt in the project which eventually gets merged into `main`. > I also share the same goal of incorporating a broad set of suggestions and comments from the wider community as part of the development process and would love to experiment ways to enable that together in the agile branch development. As an open source project, there needs to be a better balance between merging things quickly and allowing people visibility of changes - minimally this is at least leaving a large PR such as this open for a few days before merging (as specified in our [code review guidelines](https://github.com/apache/tvm/blob/main/docs/contribute/code_review.rst)) to allow others to comment and being respectful of those who do take the time to review. > Specifically, we love follow-up comments and suggestions in this PR thread or forum threads for topics related to this PR (and not close such opportunities at the merge point). We would love to see additional valuable comments that can be made as follow-up requests in the PR thread, forum, or community meetings. As someone who owns the maintenance of related areas, I will do my best to address them in a continuous fashion. As I mentioned above, should you wish to merge `unity` into `main`, I would suggest following practices established within the project ([code review guidelines](https://github.com/apache/tvm/blob/main/docs/contribute/code_review.rst)) rather than excluding the wider community, there's good advice on [community participation](https://github.com/apache/tvm/blob/main/docs/contribute/code_review.rst#community-participation) detailing a lot of the issues raised above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
