mkatanbaf commented on code in PR #13885:
URL: https://github.com/apache/tvm/pull/13885#discussion_r1100821846


##########
apps/microtvm/zephyr/template_project/src/aot_standalone_demo/main.c:
##########
@@ -229,13 +180,13 @@ void serial_callback(char* message, int len_bytes) {
 }
 
 void main(void) {
+  UARTInit();
+  TVMPlatformInitialize();
   g_cmd_buf_ind = 0;

Review Comment:
   I guess what @areusch means here (and correct me if I'm wrong) is to init 
Uart once the platform (including memory,  rpc for example) is initialized. 
Otherwise, the received data might drop or even cause errors (by trying to 
write into memory spaces that are not allocated yet)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to