srkreddy1238 commented on code in PR #13972:
URL: https://github.com/apache/tvm/pull/13972#discussion_r1108015860
##########
src/runtime/contrib/clml/clml_runtime.cc:
##########
@@ -581,11 +583,12 @@ class CLMLRuntime : public JSONRuntimeBase {
bool ExtensionStringPresent(void) {
cl_int result = 0;
- if (workspace->platform_id == nullptr) {
- return 0;
- }
size_t reqd_size = 0;
- cl_device_id device_id =
workspace->devices[workspace->GetThreadEntry()->device.device_id];
+ if
(!workspace->IsDeviceExists(workspace->GetThreadEntry()->device.device_id)) {
+ LOG(FATAL) << "OpenCL device not found";
+ }
Review Comment:
There no point proceeding without a valid CL device for CLML too. I could
remove this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
