areusch commented on code in PR #13752:
URL: https://github.com/apache/tvm/pull/13752#discussion_r1109019885
##########
src/target/source/codegen_c.cc:
##########
@@ -631,8 +632,10 @@ void CodeGenC::PrintVecBinaryOp(const std::string& op,
DataType t, PrimExpr lhs,
}
}
+NameSupply global_name_supply = NameSupply("");
void CodeGenC::VisitStmt_(const AllocateConstNode* op) {
- std::string symbol_name = op->buffer_var->name_hint;
+ std::string symbol_name =
global_name_supply->FreshName(op->buffer_var->name_hint);
Review Comment:
@gigiblender could you advise what you think is best to do here?
##########
src/relay/qnn/op/dense.cc:
##########
@@ -242,7 +242,7 @@ RELAY_REGISTER_OP("qnn.dense")
"The quantization zero_point of the weight tensor.")
.set_support_level(11)
.add_type_rel("QDense", QnnDenseRel)
- .set_attr<FInferCorrectLayout>("FInferCorrectLayout",
QnnDenseInferCorrectLayout)
+// .set_attr<FInferCorrectLayout>("FInferCorrectLayout",
QnnDenseInferCorrectLayout)
Review Comment:
revert?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
