junrushao commented on PR #14020: URL: https://github.com/apache/tvm/pull/14020#issuecomment-1434263413
> For Q2, given the context, IMHO if we can access target information in the pass and do target binding, it's possible to avoid this new attribute. I'm not quite sure if it's expected to add target as argument for certain pass. I'm not sure if I'm missing anything, but I do think the `VerifyMemory` pass assumes the target information is always available: https://github.com/apache/tvm/blob/d7253fbc7ebdfe9ab349eb85a7db3d68260ec059/src/tir/analysis/verify_memory.cc#L180-L185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
