areusch commented on code in PR #14013:
URL: https://github.com/apache/tvm/pull/14013#discussion_r1110164180
##########
src/runtime/crt/host/microtvm_api_server.py:
##########
@@ -162,13 +161,10 @@ def generate_project(self, model_library_format_path,
standalone_crt_dir, projec
)
def build(self, options):
- args = ["make"]
- if options.get("verbose"):
- args.append("VERBOSE=1")
-
- args.append(self.BUILD_TARGET)
-
- subprocess.check_call(args, cwd=PROJECT_DIR)
+ build_dir = PROJECT_DIR / "build"
+ build_dir.mkdir()
+ subprocess.check_call(["cmake", ".."], cwd=build_dir)
+ subprocess.check_call(["make", "-j12"], cwd=build_dir)
Review Comment:
why -j12? we didn't have this one before
##########
src/runtime/crt/host/CMakeLists.txt.template:
##########
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
since additional stuff is added beyond what's here, and nothing is really
templatized, what do you think about calling this CMakeLists.txt.prelude or
something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
