ashutosh-arm commented on code in PR #14003:
URL: https://github.com/apache/tvm/pull/14003#discussion_r1112218588
##########
python/tvm/topi/arm_cpu/conv2d_spatial_pack.py:
##########
@@ -402,20 +421,18 @@ def schedule_conv2d_spatial_pack_nhwc(cfg, s, op, output):
oho, ohi = cfg["tile_oh"].apply(s, output, oh)
owo, owi = cfg["tile_ow"].apply(s, output, ow)
s[output].reorder(n, oho, owo, oco, ohi, owi, oci)
- cfg["ann_spatial"].apply(
- s, output, [ohi, owi, oci], axis_lens=[OHI, OWI, OCI], max_unroll=16,
cfg=cfg
- )
- cfg.define_knob("compat", [0, 1, 2])
- if cfg["compat"].val < 2:
- compat_axis = [owo, oco][cfg["compat"].val] # pylint: disable=R1706
- s[conv].compute_at(s[output], compat_axis)
+ cfg["ann_spatial"].apply(s, output, [owi, oci], axis_lens=[OWI, OCI],
max_unroll=16, cfg=cfg)
Review Comment:
This is a great finding :star: Can we generalize this to other schedules
where the split doubles the (maybe some of the) axes and unrolling higher up
degrades performance? Theoretically sounds reasonable. To be clear, not asking
for any modifications :smile_cat: , but this is something that needs to be paid
attention to while writing CPU schedules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
