Mousius commented on code in PR #14107: URL: https://github.com/apache/tvm/pull/14107#discussion_r1118543023
########## src/relay/backend/aot_executor_codegen.cc: ########## @@ -44,6 +44,7 @@ #include <string> #include <vector> +#include "../../target/parsers/mprofile.h" Review Comment: ```suggestion ``` ########## tests/micro/arduino/test_arduino_error_detection.py: ########## @@ -19,13 +19,13 @@ from tvm.micro.project_api.server import ServerError -import test_utils +from . import utils Review Comment: Any particular reason this is changing as part of this PR? Seems unrelated. ########## tests/micro/arduino/test_arduino_error_detection.py: ########## @@ -19,13 +19,13 @@ from tvm.micro.project_api.server import ServerError -import test_utils +from . import utils import tvm.testing @pytest.fixture def project(board, microtvm_debug, workspace_dir, serial_number): - return test_utils.make_kws_project(board, microtvm_debug, workspace_dir, serial_number) Review Comment: I think `test_utils` is clearer here, `utils` is a fairly vague term. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
