masahi commented on code in PR #14139:
URL: https://github.com/apache/tvm/pull/14139#discussion_r1119191616
##########
src/relax/transform/fuse_ops.cc:
##########
@@ -939,15 +936,13 @@ class PatternBasedPartitioner : ExprVisitor {
// conv1: R.Tensor((1, 64, 56, 56), dtype="float32") = R.nn.relu(lv)
// parent_group corresponds to the group of "conv1" above.
- auto parent_group = GetGroupForBoundVar(GetRef<Call>(call));
+ auto parent_group = GetGroupForBoundVar(binding->var);
ICHECK(parent_group);
parent_group->attrs.Set(attr::kComposite, pat_name_);
-
for (const auto& [pat, match] : matches_opt.value()) {
- ICHECK(group_map_.count(match.get()));
// Put all matching call nodes into the parent group.
if (pat->IsInstance<CallPatternNode>() && match != GetRef<Call>(call))
{
- AddToGroup(match, parent_group);
+ // AddToGroup(match, parent_group);
Review Comment:
Yeah I think we can remove this, since only the group for the binding LHS
matters in practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
