sunggg commented on code in PR #14127: URL: https://github.com/apache/tvm/pull/14127#discussion_r1120341738
########## python/tvm/relax/transform/legalize_ops/common.py: ########## @@ -39,9 +39,11 @@ ##################### Utilities ##################### -def _try_convert_to_scalar_const(expr: Expr) -> Union[Expr, bool, float, int]: +def _try_convert_to_scalar_const( + expr: Expr, python_native: bool = False +) -> Union[Expr, bool, float, int]: Review Comment: Also, it would be nice to add this potential problem we found with python_native approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
