quic-sanirudh commented on PR #14161: URL: https://github.com/apache/tvm/pull/14161#issuecomment-1452032439
Hi @yzh119, thanks for the detailed explanation. Yes I understand that `reindex_cache_read/write` might not need the extended checks. In that case, as you suggested, I agree that constraining the schedule_primitive to cases where there is only one consumer block makes sense to me. My only concern was that, applying a schedule primitive that lead to incorrect output would confuse most users. As long as we avoid that, in this case by limiting the applicability of `reindex_cache_read`, and throwing an error for illegal uses, we should be good. Besides most other primitives also have such restrictions on cases in which they work and cases where they're not expected to work. BTW, thanks again for adding this, looks really cool and useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
