Lunderberg commented on code in PR #13936:
URL: https://github.com/apache/tvm/pull/13936#discussion_r1124976096
##########
src/arith/iter_affine_map.cc:
##########
@@ -898,6 +898,11 @@ class IterMapRewriter : public ExprMutator {
PrimExpr SplitFloorModConst(IterSplitExpr lhs, PrimExpr base, PrimExpr rhs);
static void AddToLhs(IterSumExprNode* lhs, IterSplitExpr rhs, int sign) {
+ if (sign < 0 && is_const_int(rhs->extent, 2)) {
Review Comment:
Can do, and added! This was a case that was caught by other unit tests,
since the additional `RewriteSimplifier` rules prevented `DetectIterMap` from
recognizing some patterns after they had been simplfied, but a specific unit
test for this case is better than needing to track it down later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
