yongwww commented on code in PR #14191:
URL: https://github.com/apache/tvm/pull/14191#discussion_r1125485100


##########
tvm_demo.py:
##########
@@ -0,0 +1,10 @@
+import numpy as np
+import onnx

Review Comment:
   remove this file?



##########
tests/python/frontend/paddlepaddle/test_forward.py:
##########
@@ -1421,189 +1430,189 @@ def forward(self, inputs):
         verify_model(MathAPI(api_name), input_data=input_data)
 
 
-@run_math_api
-def test_forward_abs():
-    pass
+# @run_math_api
+# def test_forward_abs():
+#     pass
 
 
-@run_math_api
-def test_forward_acos():
-    pass
+# # @run_math_api
+# # def test_forward_acos():
+# #     pass
 
 
-@run_math_api
-def test_forward_abs():
-    pass
+# @run_math_api
+# def test_forward_abs():
+#     pass
 
 
-@run_math_api
-def test_forward_atan():
-    pass
+# @run_math_api
+# def test_forward_atan():
+#     pass
 
 
-@run_math_api
-def test_forward_ceil():
-    pass
+# @run_math_api
+# def test_forward_ceil():
+#     pass
 
 
-@run_math_api
-def test_forward_cos():
-    pass
+# @run_math_api
+# def test_forward_cos():
+#     pass
 
 
-@run_math_api
-def test_forward_cosh():
-    pass
+# @run_math_api
+# def test_forward_cosh():
+#     pass
 
 
-@run_math_api
-def test_forward_elu():
-    pass
+# @run_math_api
+# def test_forward_elu():
+#     pass
 
 
-@run_math_api
-def test_forward_erf():
-    pass
+# @run_math_api
+# def test_forward_erf():
+#     pass
 
 
-@run_math_api
-def test_forward_exp():
-    pass
+# @run_math_api
+# def test_forward_exp():
+#     pass
 
 
-@run_math_api
-def test_forward_floor():
-    pass
+# @run_math_api
+# def test_forward_floor():
+#     pass
 
 
-@run_math_api
-def test_forward_hardshrink():
-    pass
+# @run_math_api
+# def test_forward_hardshrink():
+#     pass
 
 
-@run_math_api
-def test_forward_hardtanh():
-    pass
+# @run_math_api
+# def test_forward_hardtanh():
+#     pass
 
 
-@run_math_api
-def test_forward_log_sigmoid():
-    pass
+# @run_math_api
+# def test_forward_log_sigmoid():
+#     pass
 
 
-@run_math_api
-def test_forward_log_softmax():
-    pass
+# @run_math_api
+# def test_forward_log_softmax():
+#     pass
 
 
-@run_math_api
-def test_forward_log():
-    pass
+# @run_math_api
+# def test_forward_log():
+#     pass
 
 
-@run_math_api
-def test_forward_log2():
-    pass
+# @run_math_api
+# def test_forward_log2():
+#     pass
 
 
-@run_math_api
-def test_forward_log10():
-    pass
+# @run_math_api
+# def test_forward_log10():
+#     pass
 
 
-@run_math_api
-def test_forward_log1p():
-    pass
+# @run_math_api
+# def test_forward_log1p():
+#     pass
 
 
-@run_math_api
-def test_forward_reciprocal():
-    pass
+# @run_math_api
+# def test_forward_reciprocal():
+#     pass
 
 
-@run_math_api
-def test_forward_relu():
-    pass
+# @run_math_api
+# def test_forward_relu():
+#     pass
 
 
-@run_math_api
-def test_forward_round():
-    pass
+# @run_math_api
+# def test_forward_round():
+#     pass
 
 
-@run_math_api
-def test_forward_rsqrt():
-    pass
+# @run_math_api
+# def test_forward_rsqrt():
+#     pass
 
 
-@run_math_api
-def test_forward_selu():
-    pass
+# @run_math_api
+# def test_forward_selu():
+#     pass
 
 
-@run_math_api
-def test_forward_sigmoid():
-    pass
+# @run_math_api
+# def test_forward_sigmoid():
+#     pass
 
 
-@run_math_api
-def test_forward_sign():
-    pass
+# @run_math_api
+# def test_forward_sign():
+#     pass
 
 
-@run_math_api
-def test_forward_sin():
-    pass
+# @run_math_api
+# def test_forward_sin():
+#     pass
 
 
-@run_math_api
-def test_forward_softplus():
-    pass
+# @run_math_api
+# def test_forward_softplus():
+#     pass
 
 
-@run_math_api
-def test_forward_sqrt():
-    pass
+# @run_math_api
+# def test_forward_sqrt():
+#     pass
 
 
-@run_math_api
-def test_forward_square():
-    pass
+# @run_math_api
+# def test_forward_square():
+#     pass
 
 
-@run_math_api
-def test_forward_sin():
-    pass
+# @run_math_api
+# def test_forward_sin():
+#     pass
 
 
-@run_math_api
-def test_forward_softsign():
-    pass
+# @run_math_api
+# def test_forward_softsign():
+#     pass
 
 
-@run_math_api
-def test_forward_sqrt():
-    pass
+# @run_math_api
+# def test_forward_sqrt():
+#     pass
 
 
-@run_math_api
-def test_forward_square():
-    pass
+# @run_math_api
+# def test_forward_square():
+#     pass
 
 
-@run_math_api
-def test_forward_swish():
-    pass
+# @run_math_api
+# def test_forward_swish():
+#     pass
 
 
-@run_math_api
-def test_forward_tan():
-    pass
+# @run_math_api
+# def test_forward_tan():
+#     pass
 
 
-@run_math_api
-def test_forward_tanh():
-    pass
+# @run_math_api

Review Comment:
   looks it shouldn't be commented out



##########
python/tvm/relay/frontend/paddlepaddle.py:
##########
@@ -296,6 +296,20 @@ def convert_concat(g, op, block):
     out = _op.concatenate(inputs, axis=axis)
     g.add_node(op.output("Out")[0], out)
 
+def convert_mish(g,op,block):
+    """Operator convert for mish."""
+    x = g.get_node(op.input("X")[0])
+    dtype = infer_type(x).checked_type.dtype
+    threshold = op.attr("threshold")
+    threshold = _op.const(threshold,dtype)
+    lhs = x * _op.cast((x>threshold),dtype)
+    one = _expr.const(1.0,dtype=dtype)
+    rhs = _op.log(one+_op.exp(x))* _op.cast((x<=threshold),dtype)
+    softplus = lhs + rhs
+    out = x*_op.tanh(softplus)
+    # op_func = get_relay_op("multiply")

Review Comment:
   looks these comments are not necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to