junrushao commented on code in PR #14227:
URL: https://github.com/apache/tvm/pull/14227#discussion_r1128994370
##########
include/tvm/script/ir_builder/tir/ir.h:
##########
@@ -430,14 +430,26 @@ void Evaluate(PrimExpr value);
* \brief Create a TIR var that represents a pointer
* \param dtype The data type of the pointer.
* \param storage_scope The storage scope of the pointer.
+ * \param size_var Whether the pointer is a size var.
* \return The pointer.
*/
-Var Handle(runtime::DataType dtype = runtime::DataType::Void(), String
storage_scope = "global");
-
-#define TVM_TIR_IR_BUILDER_DEF_DTYPE_CAST(FuncName, DType)
\
- inline PrimExpr FuncName(Optional<PrimExpr> expr = NullOpt) {
\
- DataType dtype = DType;
\
- return expr.defined() ? tvm::cast(dtype, expr.value()) : tvm::tir::Var("",
dtype); \
+inline Var Handle(runtime::DataType dtype = runtime::DataType::Void(), //
+ String storage_scope = "global", //
+ bool size_var = false) {
Review Comment:
Updated to `is_size_var` per discussion with @Hzfengsy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
