lhutton1 commented on code in PR #14232:
URL: https://github.com/apache/tvm/pull/14232#discussion_r1129405627
##########
tests/python/unittest/test_target_codegen_llvm.py:
##########
@@ -534,7 +534,7 @@ def _show_info():
(2, 2),
(-11, 11),
]:
- if end < start or dend < dstart or (dend == 0 and dstart == 0):
Review Comment:
This test seems to be checking for div by 0 at compile time due to the use
of constants, in the case of `test_llvm_div`, the div by 0 occurs at runtime,
so I don't think this is something we can check here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
