junrushao commented on PR #14233: URL: https://github.com/apache/tvm/pull/14233#issuecomment-1462607158
> could you point us to an RFC or other discussion where Span was deprecated? To clarify, I am not proposing to deprecate `Span` support in current TIR as it is right now, and its potential deprecation is subject to more careful discussion. What I am implying is not to add span in Relax, which is a different topic. > Problem 1 you're describing here has been contemplated in [TVM Explorer Infra RFC](https://discuss.tvm.apache.org/t/pre-rfc-tvm-explorer-infrastructure/13457) and the proposed/accepted solution was SequentialSpan (in other words, attach both parent spans when e.g. a further optimization on a schedule pass intermixes statements with different parent spans) I agree that SequentialSpan might solve some problem at Relay level and I fully support the RFC. The problem I pointed out in this thread is that the IR is not a tree, but a DAG, which cannot be represented simply by a context-independent `Span` class. In this case, a node should exist with the path from root, which is ObjectPath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
