yongwww commented on PR #14183: URL: https://github.com/apache/tvm/pull/14183#issuecomment-1462841675
> Overall LGTM! Thanks! Just some minor nits which can be handled in follow up PRs > > legalize_ops would throw a warning for call_dps_packed: https://github.com/psrivas2/tvm/blob/emit-te/src/relax/transform/legalize_ops.cc#L105 > > Would there be follow up PRs for cleaning up transform/backend passes which earlier checked if call_tir is calling an extern func such as > > * https://github.com/psrivas2/tvm/blob/emit-te/src/relax/backend/task_extraction.cc#L77 > * https://github.com/psrivas2/tvm/blob/emit-te/src/relax/transform/fold_constant.cc#L181 > * https://github.com/psrivas2/tvm/blob/emit-te/src/relax/transform/fuse_ops.cc#L188 > * https://github.com/psrivas2/tvm/blob/emit-te/src/relax/transform/fuse_tir.cc#L305 > * https://github.com/psrivas2/tvm/blob/emit-te/src/relax/transform/rewrite_dataflow_reshape.cc#L78 Have updated for all passes, thanks a lot for pointing them out!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
