sunggg commented on PR #14324: URL: https://github.com/apache/tvm/pull/14324#issuecomment-1475026688
Thank you for great contribution, @zxybazh! Regarding your points, 1. I left my thoughts here: https://github.com/apache/tvm/pull/14324#discussion_r1141201248 2. Like @slyubomirsky pointed out, I also want to keep single source of truth. However, this requires major refactoring to TOPI side which is also used by Relay side. So, as a temporary solution, I think it is okay to have a separate output shape computation and we can fix this when we gradually migrate to Unity topi. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
