MasterJH5574 commented on code in PR #14368:
URL: https://github.com/apache/tvm/pull/14368#discussion_r1146992703


##########
python/tvm/relax/op/unary.py:
##########
@@ -527,3 +527,23 @@ def isnan(x: Expr) -> Expr:
         The computed result.
     """
     return _ffi_api.isnan(x)  # type: ignore
+
+
+###################### Indicator operators ######################
+
+
+def stop_lift_params(x: Expr) -> Expr:

Review Comment:
   I feel it might better for us to categorize this op as a builtin one? It is 
a nop except the indicator functionality. The “unary”/“binary” class is 
basically dedicated for arithmetic operations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to