Hzfengsy commented on PR #14380:
URL: https://github.com/apache/tvm/pull/14380#issuecomment-1482254165
Thanks @janetsc for the PR. I acknowledge your valuable findings and use
cases, however, I think it's still controversial:
- On the one side, inlining constants may help to bring more information and
optimization opportunities to the callee functions.
- On the other side, it may introduce similar functions if we call the same
function with different args. e.g. the following case will generate two
different functions:
```python
y = func(x, 1)
z = func(x, 2)
```
There is a related discussion at https://github.com/apache/tvm/pull/14097
In this particular case, I recommend using another pass to inline the
constant into fused functions after FuseOps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
