tqchen commented on code in PR #14396:
URL: https://github.com/apache/tvm/pull/14396#discussion_r1147559850
##########
src/relax/ir/expr_functor.cc:
##########
@@ -752,6 +752,7 @@ Var ExprMutator::VisitVarDef(const Var& var) {
} else {
LOG(FATAL) << "TypeError: Invalid type: " << var->GetTypeKey();
}
+ this->var_remap_[var->vid] = ret;
Review Comment:
I am not too sure if we wantr to do directly remap change here, ideally such
remap should be changed in the caller side, either function def or binding
##########
src/relax/ir/expr_functor.cc:
##########
@@ -752,6 +752,7 @@ Var ExprMutator::VisitVarDef(const Var& var) {
} else {
LOG(FATAL) << "TypeError: Invalid type: " << var->GetTypeKey();
}
+ this->var_remap_[var->vid] = ret;
Review Comment:
I am not too sure if we wantr to do directly remap change here, ideally such
remap should be changed in the caller side, either function param def or binding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
