masahi commented on code in PR #14417:
URL: https://github.com/apache/tvm/pull/14417#discussion_r1151195533
##########
src/relax/ir/dataflow_matcher.cc:
##########
@@ -568,18 +574,13 @@ static bool try_match(PNode* p, RNode* r,
DFPatternMatcher* m,
commit(p, r);
// match parent patterns.
- for (auto& pparent_pairs : p->parents) {
- PNode* pparent = pparent_pairs.first;
- const std::vector<PairCons>& constraints = pparent_pairs.second;
-
+ for (auto& [pparent, constraints] : p->parents) {
bool any_cons_sat = false;
for (auto& rparent : r->parents) {
// skip if mismatch.
if (rparent->matched && rparent->matched != pparent->ptr) continue;
const auto& uses = def2use.at(rparent->ptr);
- // skip if `rparent` is not used by `r`.
- if (uses.cend() == uses.find(r->ptr)) continue;
Review Comment:
This has been removed since it seems to be always false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
