dsbarinov1 commented on code in PR #14209:
URL: https://github.com/apache/tvm/pull/14209#discussion_r1151239994
##########
include/tvm/runtime/container/array.h:
##########
@@ -580,6 +580,36 @@ class Array : public ObjectRef {
}
}
+ template <typename... Args>
+ static size_t CalcCapacityImpl() {
+ return 0;
+ }
+
+ template <typename... Args>
+ static size_t CalcCapacityImpl(Array<T> value, Args... args) {
+ return value.size() + CalcCapacityImpl(args...);
+ }
+
+ template <typename... Args>
+ static size_t CalcCapacityImpl(T value, Args... args) {
+ return 1 + CalcCapacityImpl(args...);
+ }
+
+ template <typename... Args>
+ static void AgregateImpl(Array<T>& dest) {} // NOLINT(*)
Review Comment:
This edit (NOLINT) was made on the consideration that *quote* _"Google C++
Style Guide seems to have allowed using non-const references as parameters"_.
Reference: https://github.innominds.com/cpplint/cpplint/issues/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
