masahi opened a new pull request, #14431: URL: https://github.com/apache/tvm/pull/14431
* `relax/binding_rewrite.py` is not imported by default, so we get errors like `AttributeError: <class 'tvm.runtime.object.Object'> has no attribute add` if we try to pass the C++ object to python * `DataflowBlock` member variable shouldn't be optional, but it is declared with `Optional<DataflowBlock> dfb_` and accessed via `dfb_.value()` all over the places. * `root_fn_` should be optional (e.g. when `DataFlowBlockRewrite` is used inside another `ExprMutator`) , but it's always updated via `root_fn_.value()` without checking * Other minor style updates that hopefully improve readability. @ganler @tqchen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
