ganler commented on code in PR #14439:
URL: https://github.com/apache/tvm/pull/14439#discussion_r1153776712
##########
tests/python/relax/test_dataflow_pattern.py:
##########
@@ -1034,15 +1034,6 @@ def main(
matmul2 = is_op("relax.matmul")(inp_pat, K_weight_pat)
matmul3 = is_op("relax.matmul")(inp_pat, V_weight_pat)
- # TODO(masahi): Automate addition of used_by constraints during is_op
- inp_pat.used_by(matmul1, 0)
- inp_pat.used_by(matmul2, 0)
- inp_pat.used_by(matmul3, 0)
-
- Q_weight_pat.only_used_by(matmul1, 1)
- K_weight_pat.only_used_by(matmul2, 1)
- V_weight_pat.only_used_by(matmul3, 1)
Review Comment:
I understand `used_by` can be removed now as it is implied by a function
call. However, `only_used_by` is a stronger constraint that cannot be implied
via a fn call right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
