Lunderberg commented on PR #14318: URL: https://github.com/apache/tvm/pull/14318#issuecomment-1492045135
Good point. I had been assuming that the meta-programming was restricted to `T.meta_var` and references to externally-defined values. Since it is a more general feature, having the consistency with the Python API makes sense. I think I'm comfortable closing this PR, so long as #14320 can be merged in. The constant-folding makes sense, so long as its effects are purely local. My main confusion as a user was the interaction of constant-folding (this PR) and variable renaming for `var1 = var2` (#14320). Between the two, the specific value of a dynamic parameter could result in variables being renamed across the PrimFunc, which was rather unexpected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
