echuraev commented on code in PR #14458: URL: https://github.com/apache/tvm/pull/14458#discussion_r1155722526
########## tests/python/driver/tvmc/conftest.py: ########## @@ -242,7 +242,7 @@ def tflite_mobilenet_v1_0_25_128(tmpdir_factory): @pytest.fixture(scope="session") def tflite_cnn_s_quantized(tmpdir_factory): - base_url = "https://github.com/ARM-software/ML-zoo/raw/master/models/keyword_spotting/cnn_small/tflite_int8/" + base_url = "https://github.com/ARM-software/ML-zoo/raw/master/models/keyword_spotting/cnn_small/model_package_tf/model_archive/TFLite/tflite_int8/cnn_s_quantized.tflite" file_to_download = "cnn_s_quantized.tflite" model_file = download_testdata( "{}/{}".format(base_url, file_to_download), file_to_download, module=["tvmc"] Review Comment: Not sure that it will work. After `"{}/{}".format(base_url, file_to_download)` we will get `https://.../tflite_int8/cnn_s_quantized.tflite/cnn_s_quantized.tflite`. So the url will be incorrect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
