sunggg commented on PR #14457: URL: https://github.com/apache/tvm/pull/14457#issuecomment-1495219259
It turned out the semantic of `onnx.gather` is different with current `topi.gather` that implements `pytorch.gather`. Semantic of `onnx.gather` is closer to the special case of `topi.take` that implements `numpy.take` (with explicit axis and "raise" mode). Therefore, instead of introducing a separate op, I think it would be better to re-use the existing operator. So, I decided to close this PR and take the different approach: https://github.com/apache/tvm/pull/14481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
